Besides learning Elixir and ‘getting things done’ with it, I hope to also learn how to write code that is highly readable – and therefore also easy to grasp. I still have a lot to learn in that regard, I’m sure. I try not to rush to a new problem to write a solution for and first clean up some of th…

Take those pipelines and make them their own defp functions; the case should probably be an “if”. There’s general elixir coding guidelines too. Fetch vs fetch! vs get have specific meanings, avoid is_ functions unless they are guards, Avoid variables called “value”, lol. I have a linter for that…

Thanks. I’ll look into those guidelines. And now I come to think of it. I guess my concern with readability really also extends to efficient and performant code, really. Since those can potentially also can be optimized after having gotten a initial working solution.

Regarding efficiency and performance, you could improve it by doing some of these successive Enum operations in one pass, which should avoid building intermediate lists and walk them twice. filter |> map could be re-implemented with a comprehension: |> Enum.filter(fn {key, _value} -> key >= end_…

[image] coen.bakker: |> Enum.map(fn {age, count} -> {trunc(age/bucket_size), count} end) Functional question: what is this line intended to calculate? It could return 0 for age < bucket_size, which conflicts with the definition of bucket_number_list as starting at 1. A general rule I find u…

In general I think any pure function has the potential to be understandable. You just have to load the structure of the incoming data into your brain and understand what’s happening in the steps. So this is the main point for me, make it possible for the reader to follow. Imagine someone telling a…

This is honestly a huge help. Thank you.

[image] al2o3cr: [image] coen.bakker: |> Enum.map(fn {age, count} -> {trunc(age/bucket_size), count} end) Functional question: what is this line intended to calculate? My intention was to sum frequencies by bucket (e.g. all respondents between ages 18-27, 28-37, 38-47, etc.). Trunc(age…

Love this: [image] Sebb: Imagine someone telling a story in plain english. If you lose track of the (grammatical) subject, you can’t understand the story. So in a (pure) function, the subject is some data coming in, transformed with the help of some other data structures. Hope to be able to …

I think it cleaned up nicely already. Must say: has been very instructive exercise. defmodule SurveyWeb.Structs.Bins do defstruct [:size, :start, :count] def index_of(value, bins) when value >= bins.start + bins.size * bins.count do bins.count - 1 end def index_of(value, bins) do …

Just a minor note, by convention, the functions in a module for a struct should take the struct as a first argument, if that makes sense. Or generally, not just for structs, if the module is a noun, (List, String, Registry, etc)

Beyond code that gets it done: code readability. Any advice?

Questions & Help Questions

coen.bakker June 27, 2022, 8:44pm 9

Love this:

Hope to be able to put this in practice more.