Hi I have been going through the Cldr docs and I don’t see a clear way to do this. How can I configure Cldr so I can overwrite the to_string function for certain things? In particular I want to write the formatter so money: <%= @money %> is displayed as "$20" if the amount is {:USD, 20} and dis…

I have pushed commit 72f78b4 to ex_money master branch implementing your suggestion. The changelog entry reads: Enhancements Adds configuration option :exclude_protocol_implementations to omit generating implementations for one or more protocols from the list Json.Encoder, Phoneix.HTML.Safe and Gr…

[image] slouchpie: In particular I want to write the formatter so money: <%= @money %> If this in phoenix templates? If so then you likely want to implement Phoenix.HTML.Safe for the Money struct.

I’m using Money v6.0.0 — Documentation It already has the Html.Safe protocol implemented.

OK cool it finally “clicked” for me. I just put this in my code: defimpl Phoenix.HTML.Safe, for: Money do def to_iodata(money) do "this is how I do it!" |> Phoenix.HTML.Safe.to_iodata() end end and now my money looks however I want it to look. Thanks @LostKobrakai

Oh, interesting. I’ll look at adding that as an implementation on the next version of ex_money. I’m only just now getting back to web dev and hadn’t realised there is both the Html.Safe and Phoenix.HTML.Safe protocols (and maybe there isn’t a difference any more!) D’Oh, should have read my own cod…

For illumination, here is exactly the code I ended up writing: defimpl Phoenix.HTML.Safe, for: Money do def to_iodata(%Money{amount: %Decimal{coef: coef, exp: 0}} = money) when is_integer(coef) do money |> Money.to_string!(fractional_digits: 0) |> HTML.Safe.to_iodata() e…

[image] kip: You can actually store formatting options in a Money.t if you need I don’t understand this. Can you provide an example? UPDATE: ignore this. I understand you mean Money.new(..., options). Sadly, this doesn’t fit my needs. I need to fully override the protocol. Would it be possi…

Thanks for the explanation and I understand the use case. Let me think on this and revert soon.

As of commit 8c14f4f there is a compile-time option to configure whether or not the default protocol implementation is defined. The changelog entry is: Add :define_phoenix_html_safe as a compile-time configuration option. The default is true. If set to a falsy value then the default protocol impl…

It’s really cool that you decided to make this possible. I wonder if maybe there is a more extensible approach? What comes to mind is a compile-time configuration option :exclude_protocol_implementations with default []. If set to, e.g. [Gringotts.Money, Inspect, Jason.Encoder] then these 3 protoc…

I used the latest commit with our project and it works perfectly. Thanks @kip for your consistently beautiful and prolific work.

Cldr.Number custom formatter

Questions & Help Questions

LostKobrakai January 25, 2022, 6:18pm 2

If this in phoenix templates? If so then you likely want to implement Phoenix.HTML.Safe for the Money struct.