Hey, I got a list of structs which I need to convert to a map (or similar useful data structure) that I can then further use to create some Prometheus metrics. Here is what I got. The code is quite dirty in my opinion and maybe there is a smarter way to do it. I wrote it last night at 1am just to …

[image] Phillipp: How would the Enum.reduce/3 version look like? Actually, Enum.into/3 would suffice: |> Enum.into(%{ [state: "active", health: "healthy"] => 0, [state: "active", health: "unhealthy"] => 0, [state: "paused", health: "healthy"] => 0, [state: "paused", health: "…

The first step could probably be simplified to: input |> Enum.group_by(& { (if &1.pause, do: "paused", else: "active"), (if is_nil(&1.response), do: "unhealthy", else: "healthy") }) Now one might Enum.reduce/3 if zeroes are indeed required, otherwise Enum.map/2 would work: ... |> Enum.map(fn…

I thought about the group_by before but couldn’t wrap my head around it last night. Zeros are indeed required, otherwise the time series are missing. How would the Enum.reduce/3 version look like?

That worked wonderfully. I was even able to simplify my for comprehension. series = for {[state: state, health: health], value} <- extract_labeled_data(trackers) do {[state: state, health: health], value} end

[image] Phillipp: I was even able to simplify my for comprehension. Eh. Map.to_list/1 after Enum.into/3 would do exactly the same.

Yeah true. But I will keep the for in my code so it’s easy to see how the data looks like.

At least you might be slightly more DRY: [image] Phillipp: series = for {[state: state, health: health], value} = item <- extract_labeled_data(trackers), do: item

Help cleaning up this data transformation code

Questions & Help Questions

mudasobwa May 29, 2019, 10:47am 8

At least you might be slightly more DRY: