Here’s my take on it:
IO.inspect socket.assigns
if (socket.assigns.user && list_completed?(socket.assigns.list_id)) do
email = socket.assigns.user.email
list_id = socket.assigns.list_id
send_completion_notification(email, list_id)
IO.puts "All tasks complete!"
put_flash(socket, :info, "All tasks complete! Sending notification to #{email}...")
else
IO.puts "Nope, either no user, or list not complete yet..."
socket
end
# ....
defp send_completion_notification(email, list_id) do
Task.Supervisor.start_child(Organizer.TaskSupervisor, fn ->
IO.puts "Sending to #{email} from within a Task"
list_url = "https://organizer.gigalixirapp.com/#{list_id}"
Organizer.Mailer.send_completion_notification(email, list_url)
end)
end
If possible, I like to avoid rebinding (the socket = ...something that uses socket... pattern) partly because it adds indentation and partly because it’s a warning sign of complexity.
Sometimes you can avoid that by shuffling operations; this version starts the task before calling put_flash (versus the original that does the reverse) but there shouldn’t be any observable side-effect.
I broke send_completion_notification out into a private function to keep the main chunk of code focused at a single level of abstraction: manipulating socket’s contents.
Bigger tidying that could be done, depending on the context: is there something that ensures socket.assigns.user is set before this code runs? If so, consider skipping the re-check in the if clause and Let It Crash.
