Hello! So I currently have the following problem: I want to take a map and “sanitize” all the integers fields. Basically verifying if that field value is really an int and replace the parsed value in the map, furthermore, if the verified value is not an valid int it should save nil to the field, fo…

[image] rmoretto: |> Enum.filter(fn {k, _v} -> Atom.to_string(k) |> String.starts_with?("int_") end) # Remove all fields that are nil or ints |> Enum.filter(fn {_k, v} -> !is_integer(v) and !is_nil(v) end) You could simplify in one pass… |> Enum.filter(fn {k, v} -> cond1(k)…

You can give this a try, it is using tail recursion but not fully tested def parse(m) when is_map(m), do: parse(Map.to_list(m), []) def parse([], acc), do: Enum.into(acc, %{}) def parse([{k, v} | t], acc), do: parse(t, prepend({to_string(k), v}, acc)) def prepend({"int_" <> _ = k, v} ,acc)…

Another option is to use reduce. You can map the key/value pairs into a new map to get the desired result. You can also break your code out into smaller functions that do one thing to make your code more readable. Many different ways to do it. Just a matter of taste. def parse_map_int_fields(map)…

[image] rmoretto: test_map = %{ int_a: "1", int_b: "not_a_int!", str_a: "This is a string field", str_b: "Another string field", fl_a: 0.0 } Reduce is fine and a single iteration: @spec reshape_map_int_fields(map) :: map def reshape_map_int_fields(map) when is_map(map), do: Enum.…

I haven’t benchmarked, but you could do something with a for comprehension iex(103)> map = %{ ...(103)> int_a: "1", ...(103)> int_b: "not_a_int!", ...(103)> other: "leave me alone" ...(103)> } %{int_a: "1", int_b: "not_a_int!", other: "leave me alone"} iex(104)> for {k, v} <- map, match…

Thanks people for all the responses! Indeed a lot of way to approach the problem, I will probably use the @amnu3387 response just because is a little bit faster, but as Eric said, is just a matter of taste, and all other options would be completely fine. Thanks again for the help! The benchmark r…

I like this approach. Simple elegant solution. Never thought about match?

[image] amnu3387: def maybe_reshape(k, v) when is_atom(k) and not is_integer(v) and not is_nil(v) do you can optimize it even more: def maybe_reshape(k, v) when is_atom(k) and is_binary(v) do

Additionally, IIRC correctly it could be faster to reduce into a keyword list and convert that to a map with :maps.from_list. You iterate twice the list though. I would like to see the benchmarks.

[image] eksperimental: you can optimize it even more: def maybe_reshape(k, v) when is_atom(k) and is_binary(v) do Yeap, you beat me to it. I think that if I was writing this I would probably do: @spec reshape_map_int_fields(map) :: map def reshape_map_int_fields(map) when is_map(map), do:…

Help to simplify/optimize a function

Questions & Help Questions

eksperimental May 5, 2021, 3:42am 9

you can optimize it even more:
def maybe_reshape(k, v) when is_atom(k) and is_binary(v) do