How to improve this code?

[NobbZ]

@Fl4m3Ph03n1x

I had to define is_upper_case? and is_lower_case? for characters. Isn’t there a built in function that already does this?

No, there is not.

@Fl4m3Ph03n1x

In my Enum.map I have a function that I would like to extract into a defp , for the sake of clarity. But I still don’t know how to do it and I only found answer that tell me how to use anonymous functions with the terse syntax. How would I call an already defined function that takes more than 1 parameter inside an Enum.map ?

Enum.map(list, &your_defp_fun(&1, shift))

At least when I understand you correctly.

@Fl4m3Ph03n1x

I am using a conditional, even though I have the feeling I shouldn’t be using one yet . The exercise is supposed to be about string only but I am already using control flow. I have the feeling I am over complicating. Perhaps there is a simpler solution?

Don’t take the abscense of the control flow label too strict. those labels are relatively new and they haven’t been applied thoroughly yet. This is a problem common to most tracks.

---

Have you considered using a Range and charliterals? eg. char in ?a..?z.

But in general I think it looks quite good already.