Background After reading Elixir in Action I came with a (slightly modified for my evil purposes) module that I very originally call the ProcessRegistry. Now this module works and is fine, it also has a behaviour defined, but everything is in the same file and it feels tangled to me, specially after …

[image] Fl4m3Ph03n1x: For the first point, I don’t really think there will ever be another implementation of ProcessRegistry that doesn’t use Elixir’s Registry . Yes, I could go on an adventure and re-invent the wheel, but what for? How many of you had to re-implement registry’s functionality f…

I’m using Dave’s approach in my current project. I really like splitting the API apart from the implementation and the server apart from the code that produces the served data. Even my largest modules are only about 300 LOC, which I find quite manageable. FWIW, here is the lib directory for one of …

I really like to have the GenServer and the implementation separated from each other. straw_hat_twitch/lib/straw_hat_twitch/irc at master ·... master/lib/straw_hat_twitch/irc Twitch API client. Contribute to straw-hat-labs/straw_hat_twitch development by creating an account on GitHub…

[image] Fl4m3Ph03n1x: How can I improve this module and this code? I don’t really understand the purpose of this module. In a real project, I’d likely delete this code and use Registry directly. If you really insist on having this module, the second best simplification would IMO be to remove…

Hello @mark_lemberg and welcome ! Could you elaborate on why you agree with Dave and how you would apply his opinion to the piece of code I provide in the question?

I think looking for universal rules would not ever work and is a distraction in general. I’ll post one of mine though since it proved itself as a time saver many times. I draw the line at how complex would a file be for me to parse by eyeballing. For most simple(-ish) GenServers I leave everything …

Another goal of the article seemed to be encapsulation of data inside the process. In objects the advantage of encapsulation is two-fold: only the object’s methods can mutate the internal data client objects couple with the interface (API), not the structure of the internal data. In Elixir value…

[image] Fl4m3Ph03n1x: It’s a fairly small file with 53 lines, but it has a couple of things that bother me: I wouldn’t particularly argue against the code you have. I’m not sure I’d have the interface module unless I knew there’d be more implementations, and I’d do the types a little differen…

Thank you so much for your criticism. It is clear from your post I have a long way to learn about giving my opinions, you share yours in such a nice way that in comparison I look like Hitler when sharing mine :smiley: I quite like the idea of separating the Server from the API, but at the same tim…

[image] pragdave: What I’m less keen on is the start_link/child_spec magic in here. As far as I can tell, the API code would still run fine if these two were moved into a separate module IMO, starting required processes is the part of the API of an abstraction, just like constructor is the pa…

How would PragDave separate this code?

Questions & Help Questions

pragdave May 9, 2019, 5:50pm 22

Not all all.

I’m suggesting separating lifecycle concerns from functional concerns within the same codebase, that’s all.