I thought I would make one of these “improve this code” posts even though this problem isn’t really at that interesting (but here we are). I don’t hate my solution but I feel like it could perhaps be a little more readable. I’m not sure. It’s not bad, but maybe it could be better? Maybe there is…

YMMV as to where this falls on the golf-vs-readability spectrum, but it’s shorter: def segment_path(s) do s |> String.split("/", trim: true) |> Enum.scan({nil, ""}, fn el, {_, path} -> {el, "#{path}/#{el}"} end) end The tricky part here is that we only care about part of the “accumulat…

Here’s another option! def segment_path(path) when is_binary(path) do segments = String.split(path, "/", trim: true) paths = Enum.reduce(segments, [], fn segment, [] -> ["/#{segment}"] segment, [head | _tail] = whole -> ["#{head}/#{segment}" | whole] end) …

Another way: def segment_path(path) do path_levels = path |> String.split("/", trim: true) |> length() path |> breadcrumb() |> Stream.iterate(fn {segment, segment_path} -> parent_path = String.replace_trailing(segment_path, "/#{segment}", "") breadcrumb(parent_p…

Awesome, thank you all for your responses! Enum.scan.3 is actually what I was looking for, but the name didn’t poke out to me. Looks like I need to just do another read-through of the entire Enum module as it’s been quite a while. Stream.iterate/2 is super interesting and was wholly unaware of it…

Still a newb so looking for feedback on if this would work: defmodule ExampleModule do @doc """ Takes a path and returns a list of tuples in the form of: [{"segment", "/path/to/segment"}] ## Examples: iex> ExampleModule.segment_path("/path/to/segment") iex> [{"path", "/path"}, …

[image] sodapopcan: Enum.scan.3 is actually what I was looking for, but the name didn’t poke out to me. Looks like I need to just do another read-through of the entire Enum module as it’s been quite a while. +1 haha. Wonder what your final solution is as a certain lib I am building could use …

This was for one of my several abandon projects so it never grew. At one point I had my personal site in LiveView until I decide to switch over to Hugo. This is what I landed on but it didn’t have time to grow. It’s based off of @al2o3cr ’s first suggestion suggested along with a component. I jus…

Just my 2 cents if I was a reviewer: I’d recommend keeping your original code to segment the path - the new code might be more efficient, but I’d care more about readability than efficiency in code that deals with a string and resulting list of maybe 5 items. Rename the private functions to someth…

For utility functions like these that do one very simple tiny thing that will very likely never change (and I wish were just in a library), I prefer them to be terse. When they take up a lot of lines it psychologically makes me think they are doing something really important when skimming through c…

do_ for recursive functions is something the core team has explicitly moved away from, on the base that it’s just lazy naming, and leads to move your core logic into a private function - which is like stuffing your mess into a closet, close the door and call the room “cleaned up” :slight_smile: My …

In complex cases for sure—I did a little parser thing once and didn’t use do_ at all, but I honestly don’t write a lot of recursive functions. I mostly do simple cases and (and I’m entering into mega bikeshed territory here) I hate when things have names for the sake of having names… if that makes …

Improve this code?

Questions & Help Questions

BartOtten March 3, 2023, 12:19pm 7

+1 haha. Wonder what your final solution is as a certain lib I am building could use this as extension…