I thought I would make one of these “improve this code” posts even though this problem isn’t really at that interesting (but here we are). I don’t hate my solution but I feel like it could perhaps be a little more readable. I’m not sure. It’s not bad, but maybe it could be better? Maybe there is an existing way to do this? I am aware of breadcrumble_ex but it’s too explicit for my use-case. I’d also like a better name, though not putting that on you all.
So this function takes a URI path (eg. /path/to/some/place) and turns it into a list of tuples suitable for a presenter to blindly turn it into breadcrumbs. Here it is:
defmodule ExampleModule do
@doc """
Takes a path and return a list of tuples in the form of:
[{"segment", "/path/to/segment"}]
## Example:
iex> ExampleModule.segment_path("/path/to/segment")
iex> [{"path", "/path"}, {"to", "/path/to"}, {"segement", "/path/to/segment"}]
This is useful for making breadcrumbs.
"""
def segment_path(path) when is_binary(path) do
path
|> String.split("/")
|> Enum.reverse()
|> do_segment_path([])
end
defp do_segment_path([""], acc), do: acc
defp do_segment_path([segment | rest] = path, acc) do
path =
path
|> Enum.reverse()
|> Enum.join("/")
acc = [{segment, path} | acc]
do_segment_path(rest, acc)
end
end
That’s it!
Not too exciting, I know. I mostly like this little problem since this is one of those cases where building a list from the end is actually what we want to do. Of course, this just means we reverse it at the beginning as opposed to the end, and then again each iteration to put each segment in its correct form. That’s the big thing I think I would find confusing about this coming back to it later with no context.
Code-golf answers are welcome, but I’m ultimately looking for readability improvements.
