I go through bouts of playing around with re-writing source-code using Sourceror . It generally goes: I learn a whole bunch, start getting comfortable with it, stop doing it for many months and forget everything :expressionless: I’m back at it and just finished creating a function that will inline …

Is the idea here to unpipe everything next/down from the current zipper? I think your code would turn this socket |> assign(:foo, "foo" |> String.trim()) into this: assign(socket, :foo, String.trim("foo")) Is that what you’re aiming for?

Yes, any single pipes, though that particular case I did not account for! It does indeed work here though it adds new lines (which is a separate general issue I’m dealing with). These were my test cases so far (not super thorough): defp run(string, func) do result = string |> Sourceror.…

Ahhh, interesting. Only pipes where there isn’t a 2 or more pipes. Neat idea :slight_smile: In that case your traverse + prev/next strategy looks like the best way to go about this IMO. It’s a benefit of Zipper that you actually don’t need an accumulator to do this kind of thing. It would only add c…

The new line change likely is just coming from the fact that the code is formatted when you stringify it? Probably nothing to be done there?

[image] zachdaniel: Ahhh, interesting. Only pipes where there isn’t a 2 or more pipes. Yes, I just started on a new team that inherited a codebase where it’s rampant. I’m not too fussed about “no single pipes” depending on how they are used, but they are everywhere to point it’s making code …

Ah, right. I think what you can do is check if the node previous to the top node is {:__block__, meta, [just_one_thing]} and if so, replace that node instead? Might mess w/ your traversal though.

Ok, I may be celebrating early but simply setting empty meta solved it. {:|>, _, [var, {func, _, args}]} <- node do Sourceror.Zipper.replace(zipper, {func, [], [var | args]})

I’ll keep an eye out for this, thanks!!

Turns out the real answer is “just use recode ” which I totally forgot about. Was a good learning experience regardless :slight_smile:

[image] sodapopcan: I go through bouts of playing around with re-writing source-code using Sourceror . It generally goes: I learn a whole bunch, start getting comfortable with it, stop doing it for many months and forget everything :expressionless: Based on your proclivity for source code rew…

Elixir Programming Language Forum

Improve this `unpipe` function?

Questions & Help Questions

slouchpie June 24, 2024, 2:53pm 12

You can also use styler | Hex to fix single pipes.