Hey, I am currently building an api gateway. That means it receives a request and makes one or more requests to other sources and returns a response. Now I want to add metrics about the outgoing requests to my Prometheus metrics. Things like hostname, path, method and response code. That way, I a…

I don’t have an answer about catching the function calls but…To me the wrapper module is the way to go. It helps you to decouple your code from HTTPoison dependency itself, leaving you the freedom to change the HTTP library in the future if you want, without refactoring the whole code. It would also…

I often see no point in wrapping certain things just because I could eventuell change the underlaying library or framework. Practically this never gets done, at least in my experience. I also kinda dislike redoing apis that already exist because one often ends up with a very limited api that needs t…

to me, in general, it’s more about decoupling from third-party libraries rather than add functionalities. This helps me a lot in testing.

Ok, but do you wrap Ecto, Phoenix, or even Telemetry itself? At some point and for certain things it makes not much sense to wrap them.

you don’t need it because you have great testing tools in Ecto and phoenix. Those, in someway, are core libraries. If you haven’t read Mocks and explicit contracts is really interesting and talks about it. But sorry, I didn’t want to move the thread to the decoupling and testing topic sorry :smile: …

[image] Phillipp: Already a topic https://github.com/edgurgel/httpoison/issues/383 Nice, this would be great!

This doesn’t exactly answer your question but you might check out Tesla as an alternative to HTTPoison. It supports telemetry amongst other things and it’s a good model for building http clients.

Intercepting HTTPoison/hackney requests

Questions & Help Questions

alvises May 17, 2019, 11:47pm 7

Nice, this would be great!