Hello I wrote a very simple tool on Elixir to get notified on Slack when someone mention you in and issue on Github. The project use Plug and I recently added a fix for a specific behavior of the github’s api but I’m not sure about what I did. The change is small (don’t be scared about the 187 li…

Hey! I have a few comments on web.ex as a whole: web.ex:27 cond can simply be an if/else expression web.ex:50-55 should be possible to split this method using pattern matching (e.g. def valid_github_payload?(%{"issue" => _issue} = body_params, [{"x-github-event", "issue_comment", ...}])), Yo…

I made the changes : Fix first github call when creating webhook by benoittgt · Pull Request #16 · benoittgt/PhubMe · GitHub It’s much better now. I see a little bit of duplication between valid_github_payload? and handle_github_payload. But the method are readable.