Well, after the mess my last project in Python ended up being, I’m committed this time to make the cleanest code possible. Before I get any bad habits, I’d appreciate a second set of eyes on the code below. If you see any bad directions I’m going down, or ways to make the code cleaner, I’d really …

I don’t see any red flags but here are couple refactor suggestions: total_column_percent seems to be a temporary variable that can be replaced by pipe: total_pyramid_percent = prices |> calc_total_column_percent(initial_percent) |> total_pyramid_percent = calc_total_pyramid_percent() similar …

You’ve written a perfectly straightforward translation of a typical procedural language module into Elixir. So as far as that goes I can’t find much to “fix” in the module. However, there’s a kind of larger problem at the architectural level. The way that I find most useful to design Elixir program…

[image] Emily: How would I make this code cleaner? (Pipeline operator? Recursion maybe?) def calc_pyramid_prices_percents(prices, initial_percent) do total_column_percent = calc_total_column_percent(prices, initial_percent) total_pyramid_percent = calc_total_pyramid_percent(total_column_…

Thanks for all the input. I have refactored the module accordingly. …still wrapping my head around bbense post, and how I would architect this with 1-3 arity on the last steps. Seems I would have to break up the process into several more parts. My concern is that would add processing overhead,. …

I would lose all the calc_ prefixes wherever possible. For me, at least, it makes the code harder to read, with no significant benefit. :smiley:

Eh, I kind of like those kind of prefixes myself, they are descriptive…

well there is an easy way to check that : Try and benchmark :slight_smile: in general, it should not matter too much. There are quite a bit of time where i would have looked at the problem a bit differently. I agree with @delameko post on top to try to clean it a bit. About recursion : in general…

As mentioned, its a personal preference. I find the general abstraction of “PyramidCalculator” gives enough context that the thing is a calculator…

Ok, basically everything @bbense already said, but felt it would be helpful to provide an example, seeing as many people have done the same for me in the past. I had a play around with your code and came up with an alternative version; might give you some ideas; I don’t claim its better, but for me…

[image] Emily: I’m committed this time to make the cleanest code possible. I just felt compelled to point out that this is a life long mission. It’s often a worthy road to travel, but don’t be frustrated if you never arrive. The journey’s the important bit. Also, there are sometimes good r…