Hi, I am writing the Elixir integration for AppSignal, an application metrics solution. As of such, I am looking for a way to decorate functions in a developer-friendly way, so that these functions are automagically wrapped with library calls to measure the time it took to execute them (and send th…

Thanks José for your reply. At the time, overriding Kernel.@ felt like the only solution, but I’ll revisit this based on your example. Your solution looks elegant – I never knew you could override a function from within the same module. I’m still wondering how to do multiple decorators without insp…

[image] arjan: 2 @decorate module attributes below each other just causes the last one to overwrite he previous value They wont if you define the attribute like Module.register_attribute __MODULE__, :decorate, accumulate: true, then it will be a list (latest attr value would be first), and …

Yeah, didt think of that option, should be doable!

Here’s the usage of the decorator I implemented. defmodule ProgressDecorator do use Decorator.Define, [progress: 0] def progress(body, context) do quote do reply = unquote(body) case reply do list when is_list(list) -> Progress.incr(unquote(context.name), length(list))…

I’m getting there but there’s one issue with this approach, and that’s when decorating a private function, Elixir raises a warning that defoverridable is deprecated for defp’s. Any suggestion on how to address this? I guess the easiest way is to stop supporting decorators for defp altogether …

[image] arjan: Any suggestion on how to address this? Let me get back to you in a day or two.

Only supporting decorators for public functions would be an acceptable restriction.

We have removed the warning on the v1.4 branch. On the upcoming v1.4.1, private functions will be once again overridable without warnings. On master we have cleaned up the implementation and we also allow private macros to be overridable (something that was never supported).

Reviving this one because I’m really excited about @arjan ’s decorator lib, and yet @josevalim @OvermindDL1 and @benwilson512 all expressing discontent over this pattern. We want to use decorators to perform validation on controller actions and channel functions; we are using elixir/phoenix strictly…

Elixir Programming Language Forum

Nicest way to emulate function decorators?

Questions & Help Questions

NobbZ May 13, 2017, 6:36am 36

Create a function which does your thing and use it.