Query one-to-one relationship data in :create action

Questions & Help Questions
,
4

Small notes about those steps:

  • First step is unclear as employee_id should have been available before, so no comment.

  • Second step has a lot of redundancy. 1) No need to specify get? true if get_by is used. 2) No need for argument :tenant as all actions have opts that include tenant. So the same action can be written as:

read :get_by_code do
  get_by :code
end
  • 3) But even that is not needed as I see that you use code interface to invoke the action. In that case you don’t actually need custom action at all and can use default read (that’s assumes that you have one) with get_by option like this:
code_interface do
  define :get_by_code, action: :read, get_by: :code
end
  • Third is step is okay one. To pass tenant with new step two you would do tenant: changeset.tenant as the second argument. 1) You have attribute_writable? true for employee_id but if you did it only for Changeset.change_attribute to work then you can remove the option and use Changeset.force_change_attribute. 2) In my opinion better to rename tag_id argument to tag_code for clarity. 3) Based on code it seems like the argument must be present, so good to add allow_nil?: false.