In LiveViewTest’s implementation of open_browser, it creates a temp file. To name that, it implements a function that generates a bunch of random bytes which is used to make a filename that looks like: "phx-#{random_id}". The function looks like this: def random_id do "phx-" |> Kernel.<>…

[image] sodapopcan: what’s wrong with simply using "phx#{System.unique_integer()"? Absolutely nothing. :smiley: Though to remove that last 0.01% chance of collision I’d do it only slightly differently, like so: def random_id do "phx-" |> Kernel.<>(random_encoded_bytes()) |> St…

[image] dimitarvp: Absolutely nothing. :smiley: I didn’t think so, but then why the extra ceremony? The only reason I’ve got then is that they already have Phoenix.LiveView.Utils.random_id so may as well use it! Unsure. Anyway, it’s a bit curious though, like, not the most interesting myst…

[image] sodapopcan: I didn’t think so, but then why the extra ceremony? I would think they wanted to add more entropy without incurring the extra performance hit of :crypto functions.

But they are using a :crypto function in random_encoded_bytes.

They are? :thinking: At least I’m not seeing it in the code you posted.

@smathy Hey, that’s a good thought! @dimitarvp in this function: defp random_encoded_bytes do 8 |> :crypto.strong_rand_bytes() |> Base.url_encode64() end Unless strong_rand_bytes simply just lives in that module… I’m a bit of a buffoon about this particular stuff.

Ummm, but that was just my idea how it can be rewritten…

[image] sodapopcan: I’ve thought on it a bunch but can’t come up with an answer. Not sure why it would be useful, but the more-complicated approach has some additional properties: leading with system_time means that a temp file that sorts later in lexicographic order was created later using…

I think our wires may be getting crossed! That :crypto. strong_rand_bytes code is in LiveView. I was assuming by your response about crypto that System.unique_integer wraps a crypto function.

Oh interesting. That’s good info, thank you!

Elixir Programming Language Forum

Tmp files - what’s wrong with using "phx#{System.unique_integer()"?

Questions & Help Questions

smathy February 19, 2024, 8:08pm 6

Compatibility with pre-unique_integer OTPs?