Hello, I am still an Elixir newbie. To learn I keep on asking questions like this… Can I improve this two functions? It feels like but I do not know how. defp get_url(team_id) when team_id > 0 do "a_url_removed_because_not_public" <> Kernel.inspect(team_id) end defp get_url(team_…

Quite possibly! Here are a couple of questions for you, that might help you: Are the URLs in the two function clauses the same? If they are, you could extract this out to either another function, or to a module attribute. Instead of using Kernel.inspect (which is meant to only be used for logging…

I’d add a guard is_integer(team_id) as any non numeric type is greater than 0. Also, I’d use string interpolation rather than inspect. Inspection in general is something I’d only use for logging, never to create a user facing string.

[image] Nefcairon: defp get_url(team_id) when team_id == 0 You might use defp get_url(0) do ...

Thanks, this is putting me forward :slight_smile:

Hm. I thought functions should be a verb as they are doing something with the data they get (I think that goes back to university days). Background of my functions is that another function needs a url (like “ domain.com?n=1 ”) and some additional paramenter (so “ domain.com?n=1&m=[team_id] ” if some c…

[image] Nefcairon: Hm. I thought functions should be a verb as they are doing something with the data they get (I think that goes back to university days). This is not required. And if you really want to put a verb in there, get is about as vague as you can be, since it means so many differen…

Allright. Thank you :slight_smile:

A follow up question: I have to an request data from an foreign API for about 1 million times. So for every single team_id I have to contact an url, receive the data and insert (or update) the data as a new row in a database (if it meets certain conditions). I know I can do this easily via for but…

I’d probably just make: defp get_url(id) when is_integer(id) and id >=0 do "a_url_removed_because_not_public#{if(id > 0, do: id)}" end Or more readably as (since I like to pull out arg calculations onto their own lines: defp get_url(id) when is_integer(id) and id >=0 do sid = if(id > 0, do: i…

And what about my question regarding using GenServer? Too ridiculous to comment on? :dizzy_face:

It would be fun to do this with GenServer as an exercice but… It will probably become a bottleneck There are better tools to do this in OTP : GenStage, Flow or Broadway